Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
E
ElvUI
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 32
    • Issues 32
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ElvUI Project
  • ElvUI
  • Issues
  • #1649

Closed
Open
Opened Dec 27, 2019 by Rickard Moberg@XAM

Wrong UIScale for 1440p due to rounding.

All testing done with only ElvUI Installed. Version 11.27 (Development Branch, Commit 73473439)

Ever since this commit: 32a50709 that added this rounding local scale = E:Round(768 / E.screenheight, 5). The UIScale has been a little bit off for 1440p resolutions due it rounding to only 5 decimals. Havn't checked other resolutions.

Running /run print(GetScreenWidth(), "x", GetScreenHeight()) returns 2560.0161132813 x 1440.0089111328

However, if I change the rounding to 9 decimals then reset my uiscale back to 0.64 something higher and then try the autoscale feature again it is now reporting 2560 x 1440 without any decimals.

What I changed to: local scale = E:Round(768 / E.screenheight, 9)

9 was the lowest amount of decimals I could use to get a result without any decimals.

Edited Dec 27, 2019 by Rickard Moberg
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: elvui/elvui#1649