Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Shadow and Light
Shadow and Light
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Shadow & Light
  • Shadow and LightShadow and Light
  • Issues
  • #133

Closed
Open
Opened Jul 24, 2018 by Nazgul084@Nazgul084

ElvUI S&L Currencies Datatext Issues

Description ElvUI Shadow & Light Improved Currency Options Datatext defaults to sort gold by character names and factions reversed from expected alphanumeric sorting standards when "Normal" sort order by "Name" is selected. Further, numerous recent currencies are missing. Finally, clicking on a datatext for currencies, one expects to open the currencies frame, not the bags frame.

ElvUI Config > Shadow & Light > Modules > Datatexts > S&L Datatexts > S&L Currency

Shadow & Light Version ElvUI S&L 3.42 Dev Commit 5f71b9e3.

ElvUI Version ElvUI 10.78 Development Commit 317423fd.

Steps to Reproduce

  1. ElvUI Config > Shadow & Light > Modules > Datatexts > S&L Datatexts > S&L Currency
  2. ElvUI Improved Currency Options > select all
  3. Gold Sorting > Sort Direction > Normal
  4. Gold Sorting > Sort Method > Name
  5. Hover mouse cursor over datatext in a panel.

Expected Behavior When "Normal" sorting of "Name" is enabled, the expected behavior is to sort by alphanumeric standards for character and faction names, in order of A to Z, and least to greatest. Further, when the datatext is clicked, the currencies frame is expected to be opened.

Actual Behavior The sort order of character names and amounts is reversed from alphanumeric standards. When clicked, the bags frame opens.

ElvUI + S&L Enabled Yes.

Only ElvUI Enabled This feature is unique to ElvUI S&L.

Additional Information These were trivial items to fix (and accept, reject, or ignore), so...

  1. I fixed the default sort order to conform to expected norms (and reversed the Faction sort order as well).
  2. I changed the default click behavior to match the ElvUI datatext behavior, and open the currencies frame.
  3. I updated the currencies list based upon data from www.wowhead.com/currencies.
  4. Since I'm not setup properly for git, I attached the updated file.currency.lua

Error Log No error log is produced.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: shadow-and-light/shadow-and-light#133