Skip to content

GitLab

Shadow and Light
Shadow and Light
Closed
Opened by Matias@m4tjz

Armory skin enables even when it shouldn't

Description On line 8 of the file ElvUI_SLE\skins\blizzard\character.lua there is an oversight with the return statement causing the Armory skin to be half-enabled and stripping some textures from the Character Frame even when it should be disabled.

The error is on line 8:

if E.db.sle.Armory and not E.db.sle.Armory.Character.Enable then return end

Because the Armory skin was never enabled the value "E.db.sle.Armory" was never set, so it will always return as false, enabling the code to keep going and change textures.

The line should be something like:

if not E.db.sle.Armory or (E.db.sle.Armory and not E.db.sle.Armory.Character.Enable) then return end

Shadow & Light Version 3.63

ElvUI Version 11.27

Steps to Reproduce

  1. Install ElvUI_SLE on a fresh UI without enabling the Armory module.
  2. Should reproduce steps already for Character Frame to be broken.

Expected Behavior Textures should remain if the Skin is disabled

Actual Behavior Some textures of the Character Frame are removed, leaving a mess behind.

ElvUI + S&L Enabled Only ElvUI and ElvUI_SLE enabled.

Only ElvUI Enabled With only ElvUI enabled the Character Frame doesn't get it's textures stripped.

Edited by Matias